Make sure current task build id works with queries / caching #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
current-task-build-id-fix
branch
from
1312603 to
db8745d
Compare
| @@ -420,9 +418,15 @@ impl WorkflowMachines { | |||
| Some(workflow_activation_job::Variant::QueryWorkflow(_)) | |||
| ) | |||
| }); | |||
| let is_replaying = self.replaying || all_query; | |||
| let build_id_for_current_task = if is_replaying { | |||
| self.current_wft_build_id.clone().unwrap_or_default() | |||
There was a problem hiding this comment.
Does core need the same logic as Go to check for an empty build ID?
There was a problem hiding this comment.
The lookahead works a bit differently and avoids this problem - I actually ended up changing the Go one to be a bit simpler and more similar in my last fix too.
| @@ -420,9 +418,15 @@ impl WorkflowMachines { | |||
| Some(workflow_activation_job::Variant::QueryWorkflow(_)) | |||
| ) | |||
| }); | |||
| let is_replaying = self.replaying || all_query; | |||
There was a problem hiding this comment.
Aren't queries considered replaying anyway?
There was a problem hiding this comment.
Not until this point, that's where it happens
Quinn-With-Two-Ns
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Made the current task build id sent on activations consistent with what I just did in Go / Java.
Why?
Part of temporalio/features#253
Checklist
Closes
How was this tested: